Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cura suite: 4.3.0 -> 4.4.0 #75130

Merged
merged 1 commit into from Dec 7, 2019
Merged

cura suite: 4.3.0 -> 4.4.0 #75130

merged 1 commit into from Dec 7, 2019
+11 −11

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 7, 2019

Replaces #74134.

Motivation for this change

Changelog: https://github.com/Ultimaker/Cura/releases/tag/v4.4.0

Note the cura.materials hash is not updated because apparently
its contents stay the same, despite version update.

Implements comment about libarcus from:
#69435 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested cura GUI, it slices successfully.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar @gebner

@nh2
cura, python3Packages.libsavitar, python3Packages.libarcus, python3Pa…
50c8701 
…ckages.uranium: 4.3.0 -> 4.4.0

Closes NixOS#74134.

Note the `cura.materials` hash is not updated because apparently
its contents stay the same, despite version update.

Implements comment about libarcus from:
NixOS#69435 (comment)
@nh2 nh2 requested review from gebner and abbradar December 7, 2019 02:06
@nh2
Copy link
Contributor Author

nh2 commented Dec 7, 2019

@GrahamcOfBorg build

@gebner gebner mentioned this pull request Dec 7, 2019
Closed
@gebner gebner merged commit 949ebe4 into NixOS:master Dec 7, 2019
@gebner
Copy link
Member

gebner commented Dec 7, 2019

Yes it's weird, but the cura.materials hash doesn't change for me either (checked with nix-prefetch-url).

I've updated curaPlugins.octoprint to work with the new cura version: 6ddbf42

@baracoder baracoder mentioned this pull request Mar 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

@abbradar abbradar Awaiting requested review from abbradar

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @gebner