Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI check for generated tests doesn't include conformance-checkers/tools/picture.py #20649

Closed
zcorpan opened this issue Dec 6, 2019 · 1 comment
Closed

CI check for generated tests doesn't include conformance-checkers/tools/picture.py #20649

zcorpan opened this issue Dec 6, 2019 · 1 comment
Labels
conformance-checkers infra priority:backlog

Comments

@zcorpan
Copy link
Member

zcorpan commented Dec 6, 2019

See #20629

For other parts of wpt there is a CI check to run the scripts that generate tests and makes sure it doesn't cause the diff to change, thereby checking that generated tests aren't edited directly. It appears that it doesn't do this for conformance-checkers/tools/picture.py at least.

cc @sideshowbarker @jgraham
@foolip
Copy link
Member

foolip commented May 6, 2021

Fixed by #28832.

@foolip foolip closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conformance-checkers infra priority:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenmcgruer @zcorpan @foolip