Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openafs_1_8: 1.8.3 -> 1.8.5 #75104

Merged
merged 1 commit into from Dec 7, 2019
Merged

openafs_1_8: 1.8.3 -> 1.8.5 #75104

merged 1 commit into from Dec 7, 2019

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Dec 6, 2019

Motivation for this change

Addresses security advisories OPENAFS-SA-2019-001, OPENAFS-SA-2019-002, OPENAFS-SA-2019-003.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @maggesi @spacefrogg

@andersk
openafs_1_8: 1.8.3 -> 1.8.5
c4e4a82 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@ofborg ofborg bot requested review from spacefrogg and maggesi December 6, 2019 14:15
spacefrogg
spacefrogg reviewed Dec 6, 2019
View reviewed changes
Copy link
Contributor

@spacefrogg spacefrogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the cross-build patch official? Is there an upstream commit addressing this issue?

Looks good otw!

@andersk
Copy link
Contributor Author

andersk commented Dec 7, 2019

No, it’s the same patch that you added in #48571, I just tweaked the diff context so it still applies. It looks like you submitted it at https://gerrit.openafs.org/13359, where upstream is still waiting for you to fix the CentOS BuiltBot failure and address their feedback.

@veprbl veprbl added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 7, 2019
veprbl
veprbl approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on x86_64-linux (NixOS, with sandboxing)

2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.openafs_1_8 linuxPackages_hardkernel_latest.openafs_1_8

4 package failed to build:
linuxPackages_hardened.openafs_1_8 linuxPackages_latest-libre.openafs_1_8 linuxPackages_latest_hardened.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8

11 package were build:
linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_14.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8 linuxPackages_5_3.openafs_1_8 linuxPackages_5_4.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8 linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8 openafs_1_8

@veprbl veprbl merged commit b661db1 into NixOS:master Dec 7, 2019
@veprbl veprbl self-assigned this Dec 7, 2019
@andersk andersk deleted the openafs-1.8.5 branch December 10, 2019 09:01
veprbl pushed a commit that referenced this pull request Feb 4, 2020
@andersk @veprbl
openafs_1_8: 1.8.3 -> 1.8.5 (#75104)
14a7b01 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
(cherry picked from commit b661db1)
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 4, 2020
@veprbl veprbl removed their assignment Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacefrogg spacefrogg spacefrogg left review comments

@veprbl veprbl veprbl approved these changes

@maggesi maggesi Awaiting requested review from maggesi

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @spacefrogg @veprbl