Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: remove unused GLFW dependency #75189

Merged
merged 1 commit into from Dec 8, 2019
Merged

kitty: remove unused GLFW dependency #75189

merged 1 commit into from Dec 8, 2019

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Dec 8, 2019

Motivation for this change

kitty has its own heavily modified fork of GLFW embedded in the source code. Therefore it doesn't need GLFW as an external dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tex @rvolosatovs @Ma27

@Luflosi
kitty: remove unused GLFW dependency
079d57f 
kitty has its own heavily modified fork of GLFW embedded in the source code. Therefore it doesn't need GLFW as an external dependency.
@ofborg ofborg bot requested a review from Ma27 December 8, 2019 01:03
@veprbl
Copy link
Member

veprbl commented Dec 8, 2019

@Luflosi Just a thought: it would make sense if you add yourself to kitty.maintainers.

jonringer
jonringer approved these changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable/gui still launches fine

[3 built, 23 copied (76.1 MiB), 14.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75189
1 package were built:
kitty

@jonringer
Copy link
Contributor

@GrahamcOfBorg buildl kitty

@veprbl veprbl merged commit 318c986 into NixOS:master Dec 8, 2019
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 8, 2019
@Luflosi Luflosi deleted the kitty-no-glfw branch December 8, 2019 11:23
@Luflosi
Copy link
Contributor Author

Luflosi commented Dec 8, 2019

@veprbl thanks for the tip, I think I'll do that when I create the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@Ma27 Ma27 Ma27 approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Luflosi @veprbl @jonringer @Ma27