Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] firefox: fix indexedDB for 71.0 #75184

Merged
merged 2 commits into from Dec 8, 2019
Merged

[19.09] firefox: fix indexedDB for 71.0 #75184

merged 2 commits into from Dec 8, 2019

Conversation

andir
Copy link
Member

@andir andir commented Dec 8, 2019

Motivation for this change

Port of #75169 cc @Ma27 @fpletz

@Ma27 Can you also test this version of the browser?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

andir and others added 2 commits December 8, 2019 00:47
@andir
Revert "Revert "firefox: 70.0.1 -> 71.0""
d7876ad 
This reverts commit 8677b26.
@fpletz @andir
firefox: fix indexedDB for 71.0
6c79325 
Adapted original patch[0] to also fix dom localstorage.

[0]: https://bugzilla.mozilla.org/show_bug.cgi?id=1601707#c6

(cherry picked from commit a1e4ee6)
@ofborg ofborg bot requested a review from edolstra December 8, 2019 00:26
@Ma27 Ma27 self-requested a review December 8, 2019 00:35
@Ma27
Copy link
Member

Ma27 commented Dec 8, 2019

I'd be happy to test this for release-19.09 as well, however I can't promise that the firefox is built before I go to sleep, so it may be possible that I'll approve this tiomorrow :D

(OT: in case somebody else stumbles upon this issue, I posted some workarounds in #74905 (comment)).,

Ma27
Ma27 approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally, I can't reproduce the issues anymore I described in #74905 👍

@Ma27 Ma27 merged commit 2adf2d6 into NixOS:release-19.09 Dec 8, 2019
@fpletz
Copy link
Member

fpletz commented Dec 8, 2019

Thanks!

@pbogdan pbogdan mentioned this pull request Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @Ma27 @fpletz