Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache-kafka.nix: Add missing quote inside tmpfiles rule #75182

Merged
merged 1 commit into from Dec 8, 2019
Merged

apache-kafka.nix: Add missing quote inside tmpfiles rule #75182

merged 1 commit into from Dec 8, 2019

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Dec 7, 2019

Motivation for this change

rmdir /tmp/apache-kafka
then switching to a config with apache-kafka enable will make the switch fail because /etc/tmpfiles.d rules can't be applied.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ragnard

@aanderse
Copy link
Member

aanderse commented Dec 8, 2019 •
edited

Thank you @clefru! Are you going to make a backport?

@aanderse aanderse merged commit 9abf0a1 into NixOS:master Dec 8, 2019
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Jan 8, 2020
@clefru @srhb
apache-kafka.nix: Add missing quote inside tmpfiles rule
7645de2 
(cherry picked from commit 39cd457)
Backport of NixOS#75182
@srhb srhb mentioned this pull request Jan 8, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clefru @aanderse