libreswan: 3.18 -> 3.29, addressing CVE-2019-12312 & CVE-2019-10155 #75186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmry
reviewed
Dec 8, 2019
|
Superficially this looks fine to me, though I can't test anything because I no longer use the package myself... |
risicle
force-pushed
the
ris-libreswan-3.29
branch
from
db72e7e
to
98096c0
Compare
ehmry
approved these changes
Dec 8, 2019
|
What should we do regarding 19.09? I don't feel comfortable backporting the patch to 3.18 - a lot of code around this area has changed between the two versions.. but it's also quite a big bump. It's "only" a null pointer dereference, but debian seem to have classed it "grave". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2019-10155
https://nvd.nist.gov/vuln/detail/CVE-2019-12312
This is targeted at staging because of the huge rebuild - however, that rebuild is all due to the small change made to
unboundrequired to persuade it to install its libevent-support headers. I haven't tried a full rebuild of these as the addition of this header to the output shouldn't really affect other packages not looking for it. Famous last words.libreswanitself has no reverse dependencies.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @afranchuk I am not a user of this package so would appreciate some help in testing.