Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: fix amdgpu memory mapping with kernel >= 5.3 #75176

Merged
merged 1 commit into from Dec 8, 2019
Merged

linux: fix amdgpu memory mapping with kernel >= 5.3 #75176

merged 1 commit into from Dec 8, 2019

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Dec 7, 2019

These configuration options are needed for the ROCm GPU compute stack
on kernels >= 5.3.

I first discovered the need for these kernel options some time ago (probably when moving my main dev machine to kernel 5.3), and they were recently rediscovered by another nixos-rocm user. Without them, ROCm software quickly crashes when attempting to communicate with the GPU.

FWIW, these options are all enabled in the default Arch kernel configuration, afaict.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@acowley
linux: fix amdgpu memory mapping with kernel >= 5.3
fb639a0 
These configuration options are needed for the ROCm GPU compute stack
on kernels >= 5.3.
@acowley acowley mentioned this pull request Dec 7, 2019
Closed
@teto teto merged commit 8a4603f into NixOS:master Dec 8, 2019
@acowley acowley mentioned this pull request Dec 16, 2019
Closed
@acowley acowley mentioned this pull request Apr 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: kernel 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acowley @veprbl @teto