Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: replace library path using patch instead of substituteInPlace #75177

Merged
merged 1 commit into from Dec 7, 2019
Merged

kitty: replace library path using patch instead of substituteInPlace #75177

merged 1 commit into from Dec 7, 2019

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Dec 7, 2019

This makes patching the path for libEGL consistent with libstartup-notification and libcanberra.
It should also prevent silently doing nothing in case the code in kitty is changed, similar to what was described in 1842c4a.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tex @rvolosatovs @Ma27

@Luflosi
kitty: replace library path using patch instead of substituteInPlace
c562eb2 
This makes patching the path for `libEGL` consistent with `libstartup-notification` and `libcanberra`.
It should also prevent silently doing nothing in case the code in kitty is changed, similar to what was described in 1842c4a.
@ofborg ofborg bot requested a review from Ma27 December 7, 2019 22:23
@Ma27 Ma27 merged commit 91480fa into NixOS:master Dec 7, 2019
@Luflosi Luflosi deleted the kitty-change-substitution branch December 7, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @Ma27