Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ark: Add package description #75175

Merged
merged 1 commit into from Dec 8, 2019
Merged

ark: Add package description #75175

merged 1 commit into from Dec 8, 2019

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Dec 7, 2019

Motivation for this change

The KDE utility ark has no description

Things done

Trivial change: added meta.description with a copy of the first line of description from the upstream website

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel

@Thra11 Thra11 requested a review from ttuegel as a code owner December 7, 2019 21:58
ttuegel
ttuegel approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ttuegel ttuegel merged commit fd80ac6 into NixOS:master Dec 8, 2019
@Thra11 Thra11 deleted the ark-description branch December 8, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Thra11 @ttuegel