Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zabbix: various package reference fixes #75161

Merged
merged 1 commit into from Dec 7, 2019
Merged

zabbix: various package reference fixes #75161

merged 1 commit into from Dec 7, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Dec 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse requested review from mmahut and srhb December 7, 2019 17:16
srhb
srhb approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every attribute looks good and buildable, and discoverability appears to be fixed. Bot is not quite done yet though :)

@aanderse
Copy link
Member Author

aanderse commented Dec 7, 2019

Thanks @srhb! 🎉

@aanderse aanderse merged commit 83b7156 into NixOS:master Dec 7, 2019
@aanderse aanderse deleted the zabbix branch December 7, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @srhb