Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano-wallet: 19.0 -> 20.0 #75162

Closed
wants to merge 1 commit into from
Closed

nano-wallet: 19.0 -> 20.0 #75162

wants to merge 1 commit into from

Conversation

alexbakker
Copy link
Member

Motivation for this change

V20.0 was released a couple of weeks ago.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jluttine

@ofborg ofborg bot requested a review from jluttine December 7, 2019 17:26
jluttine
jluttine approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@jluttine jluttine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There is already a PR for this: #74341

So one can be merged and then the other closed. They are practically identical, so either way, doesn't matter. Anyway, looks good to me, so this can be merged.

@alexbakker
Copy link
Member Author

@jluttine Oops, my bad. I should have checked if there already was a PR. I'll close this one.

@alexbakker alexbakker closed this Dec 7, 2019
@jluttine
Copy link
Member

jluttine commented Dec 7, 2019

No worries! If you have permissions to review that other PR, probably approving it will cause it to be merged sooner..

@alexbakker
Copy link
Member Author

Good call. I don't have permissions to review, but I'll leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluttine jluttine jluttine approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexbakker @jluttine