Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gohufont: generate opentype files #75163

Merged
merged 6 commits into from Feb 13, 2020
Merged

gohufont: generate opentype files #75163

merged 6 commits into from Feb 13, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 7, 2019

Motivation for this change

See #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested in xterm, xfontsel and dunst
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj mentioned this pull request Dec 7, 2019
Closed
19 tasks
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 21, 2019

The results seems to depend on the builder OS. This is pretty bad.
I don't know how to debug this... maybe I could try to build on the community aarch64 server....

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 7, 2020

So, the cause of the non determinism was an actual bug in fonttosfnt, which I should have fixed and reported upstream.

@rnhmjoj rnhmjoj requested a review from jtojnar February 8, 2020 17:41
@rnhmjoj rnhmjoj merged commit f8c3e15 into NixOS:master Feb 13, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
@rnhmjoj @dtzWill
Merge pull request NixOS#75163 from rnhmjoj/gohu
663299d 
gohufont: generate opentype files
(cherry picked from commit f8c3e15)
@rnhmjoj rnhmjoj deleted the gohu branch April 7, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rnhmjoj