Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

souffle: 1.7.0 -> 1.7.1 #75083

Merged
merged 1 commit into from Dec 6, 2019
Merged

souffle: 1.7.0 -> 1.7.1 #75083

merged 1 commit into from Dec 6, 2019

Conversation

luc-tielen
Copy link
Contributor

@luc-tielen luc-tielen commented Dec 6, 2019 •
edited

Motivation for this change

New version of Souffle released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @copumpkin @wchresta

jonringer
jonringer approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable seems to work

[3 built, 7 copied (25.6 MiB), 5.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75083
1 package were built:
souffle

although, i noticed this:

[nix-shell:/home/jon/.cache/nix-review/pr-75083]$ ./results/souffle/bin/souffle --version
Souffle: unknown
Copyright (c) 2016-18 The Souffle Developers.
Copyright (c) 2013-16 Oracle and/or its affiliates.

@thoughtpolice thoughtpolice merged commit aaf7a7e into NixOS:master Dec 6, 2019
@luc-tielen luc-tielen deleted the update/souffle-1.7.1 branch December 6, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@jonringer jonringer jonringer approved these changes

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luc-tielen @thoughtpolice @jonringer