Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.strings.intersperse -> lib.lists.intersperse. #75102

Closed
wants to merge 1 commit into from
Closed

lib.strings.intersperse -> lib.lists.intersperse. #75102

wants to merge 1 commit into from

Conversation

pinktrink
Copy link
Contributor

@pinktrink pinktrink commented Dec 6, 2019 •
edited

intersperse is defined within lib.strings yet does not work for
strings, only lists. Furthermore, it only returns a list. There is no
sense in a function that only works with lists being in the strings
library.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@d-goldin
Copy link
Contributor

d-goldin commented Dec 6, 2019

Please fix the re-export in https://github.com/NixOS/nixpkgs/blob/master/lib/default.nix#L81 too

@pinktrink
Copy link
Contributor Author

Done.

@pinktrink
Copy link
Contributor Author

Another issue has popped up. Let me run this one through the ringer until I have a passing build.

@pinktrink pinktrink force-pushed the master branch 4 times, most recently from 42835c4 to 852a120 Compare December 6, 2019 15:08
@pinktrink
Copy link
Contributor Author

There we go. This branch is ready for merging.

d-goldin
d-goldin reviewed Dec 6, 2019
View reviewed changes
lib/strings.nix Outdated Show resolved Hide resolved
@pinktrink pinktrink force-pushed the master branch 3 times, most recently from 1b44fca to c1b3498 Compare December 7, 2019 10:55
@pinktrink
lib.strings.intersperse -> lib.lists.intersperse.
8527821 
`intersperse` is defined within `lib.strings` yet does not work for
sintersperse trings, only lists. Furthermore, it only returns a list. There is no
sense in a function that only works with lists being in the strings
library.
pinktrink
pinktrink commented Dec 8, 2019
View reviewed changes
lib/strings.nix
@@ -54,9 +54,10 @@ rec {
separator:
# Input list
list:
if list == [] || length list == 1
lib.warn "`lib.strings.intersperse' is deprecated and will be removed. Please use `lib.lists.intersperse'."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-goldin How is this?

Copy link
Contributor

@d-goldin d-goldin Dec 10, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just call lib.lists.intersperse directly here instead of duplicating the logic? A dependency on lib.lists already exists anyways below.

Edit: To clarify, I mean intersperse = lib.warn "deprecated" lib.lists.intersperse directly - or did I miss something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good call, that was a moment of stupidity. I'll fix that.

@stale
Copy link

stale bot commented Jun 12, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@d-goldin
Copy link
Contributor

d-goldin commented Nov 2, 2020

Closing this, since no reviewers with merge rights showed up. Sorry!

@d-goldin d-goldin closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-goldin d-goldin d-goldin left review comments

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pinktrink @d-goldin @ryantm