Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.polyline: init at 1.4.0 #75071

Merged
merged 2 commits into from Dec 6, 2019
Merged

pythonPackages.polyline: init at 1.4.0 #75071

merged 2 commits into from Dec 6, 2019

Conversation

ersinakinci
Copy link
Contributor

Motivation for this change

Add polyline Python package (needed to support Mapbox Python SDK).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

N/A

@ersinakinci ersinakinci changed the title polyline: init at 1.4.0 pythonPackages.polyline: init at 1.4.0 Dec 5, 2019
@ersinakinci
Copy link
Contributor Author

I've updated this PR with your suggestions, @jonringer. Thanks for your help!

jonringer
jonringer reviewed Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits, should only be two:

maintainers: add ersin
pythonPackages.polyline: init at 1.4.0

@ersinakinci
pythonPackages.polyline: init at 1.4.0
8996b69 
Add polyline Python package (needed to support Mapbox Python SDK).
@ersinakinci
maintainers: add ersin
41ff7d9
@ersinakinci
Copy link
Contributor Author

@jonringer done!

jonringer
jonringer approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
repo LGTM

https://github.com/NixOS/nixpkgs/pull/75071
3 package were built:
python27Packages.polyline python37Packages.polyline python38Packages.polyline

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.polyline python37Packages.polyline python38Packages.polyline

@jonringer jonringer merged commit 7d17a24 into NixOS:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ersinakinci @jonringer