Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano: upstream patch fixes build on MacOS #75157

Merged
merged 1 commit into from Dec 10, 2019

Conversation

bergey
Copy link
Contributor

@bergey bergey commented Dec 7, 2019

fixes #74840

Motivation for this change

Upstream patch did not make it into the 4.6 release. Thanks to @matthewbauer for finding it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cresh @joachifm

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 7, 2019
@ofborg ofborg bot requested a review from joachifm December 7, 2019 14:32
@veprbl veprbl added 9.needs: port to stable A PR needs a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 8, 2019
@matthewbauer matthewbauer merged commit 8f3ca4e into NixOS:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nano 4.6 fails to build on macOS
3 participants