Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkd: add missing "Advertise" option #75086

Merged
merged 1 commit into from Dec 6, 2019
Merged

nixos/networkd: add missing "Advertise" option #75086

merged 1 commit into from Dec 6, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 6, 2019

This is in systemd since v240.

Motivation for this change

https://systemd.network/systemd.link.html#Advertise=

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@flokli
nixos/networkd: add missing "Advertise" option
2c1281e 
This is in systemd since v240.
@flokli flokli requested review from fpletz and andir December 6, 2019 07:45
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 6, 2019
@Ma27 Ma27 merged commit 47e5b15 into NixOS:master Dec 6, 2019
@Ma27
Copy link
Member

Ma27 commented Dec 6, 2019

Thanks! Backported as 0e4d0ad.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @Ma27