Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: fix indexedDB for 71.0 #75169

Merged
merged 1 commit into from Dec 7, 2019
Merged

firefox: fix indexedDB for 71.0 #75169

merged 1 commit into from Dec 7, 2019

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Dec 7, 2019

Adapted original patch to also fix dom localstorage.

Motivation for this change

See discussion in #74905 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz
firefox: fix indexedDB for 71.0
a1e4ee6 
Adapted original patch[0] to also fix dom localstorage.

[0]: https://bugzilla.mozilla.org/show_bug.cgi?id=1601707#c6
@fpletz fpletz requested review from andir, taku0 and Ma27 December 7, 2019 19:11
@ofborg ofborg bot requested a review from edolstra December 7, 2019 19:35
@andir andir self-assigned this Dec 7, 2019
Ma27
Ma27 reviewed Dec 7, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed this issue with @fpletz this afternoon, the approach seems fine (we may want to file this patch upstream though), currently testing this locally, let's see if that resolves all the issues I'm experiencing :)

Ma27
Ma27 approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just built a firefox v71 with this patch locally, the issues I experienced due to broken storages in the browser aren't reproducible anymore -> LGTM 👍

andir
andir approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works for me (as before). Apparently I do not have any of those Add-On's installed.

@andir andir merged commit 5368791 into NixOS:master Dec 7, 2019
@andir andir mentioned this pull request Dec 8, 2019
Merged
10 tasks
@Ma27 Ma27 deleted the fix/firefox-71-lto branch December 8, 2019 00:45
@pbogdan pbogdan mentioned this pull request Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@Ma27 Ma27 Ma27 approved these changes

@taku0 taku0 Awaiting requested review from taku0

@edolstra edolstra Awaiting requested review from edolstra

Assignees

@andir andir

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpletz @andir @Ma27