Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pam_gnupg: init at unstable-2019-10-25 #75064

Closed
wants to merge 1 commit into from
Closed

pam_gnupg: init at unstable-2019-10-25 #75064

wants to merge 1 commit into from

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change

This pull request adds pam_gnupg, which allows unlocking GnuPG keys at login.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

prusnak
prusnak requested changes Dec 5, 2019
View reviewed changes
pkgs/os-specific/linux/pam_gnupg/default.nix Outdated
Comment on lines 18 to 19
name = "pam_gnupg-${rev}";
rev = "363a50820fc00d6af6f6c01b87bacab51b67cda7";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should read:

pname = "pam_gnupg";
version = "unstable-2019-10-25";

pkgs/os-specific/linux/pam_gnupg/default.nix Outdated
src = fetchFromGitHub {
owner = "cruegge";
repo = "pam-gnupg";
inherit rev;
Copy link
Member

@prusnak prusnak Dec 5, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

rev = "b2bd2b4f2650cce1bf628413089128721749578e";

and change the sha256 hash below

@dawidsowa dawidsowa changed the title pam_gnupg: init at 363a50820fc00d6af6f6c01b87bacab51b67cda7 pam_gnupg: init at unstable-2019-10-25 Dec 5, 2019
@ahesford
Copy link

ahesford commented Jan 9, 2020

I didn't see this before submitting my own PR #77002 to do the same thing. In addition to a new package, my contribution modifies the NixOS pam.nix module to properly incorporate pam_gnupg.so into the service files; otherwise, the package will not be usable to unlock GPG keys.

@dawidsowa dawidsowa closed this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidsowa @ahesford @prusnak