Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qbittorrent-nox: init at 4.1.9.1 #75068

Merged
merged 1 commit into from Dec 14, 2019
Merged

qbittorrent-nox: init at 4.1.9.1 #75068

merged 1 commit into from Dec 14, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 5, 2019

Motivation for this change

I use the qbittorrent webui on a machine that doesn't need qbittorrent's Qt GUI.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I confirmed that it is linked to far fewer shared libraries with

ldd /nix/store/gn39sbq7w30rqyd6z18153c285midhn7-qbittorrent-4.1.9.1/bin/.qbittorrent-nox-wrapped
Notify maintainers

cc @Anton-Latukha

Copy link
Contributor

@Anton-Latukha Anton-Latukha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Thank you.

@dywedir dywedir merged commit 942de23 into NixOS:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants