Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radarr: 0.2.0.1358 -> 0.2.0.1450 #75166

Merged
merged 1 commit into from Feb 11, 2020
Merged

radarr: 0.2.0.1358 -> 0.2.0.1450 #75166

merged 1 commit into from Feb 11, 2020

Conversation

nyanloutre
Copy link
Member

Motivation for this change

The radarr test is passing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo

@ofborg ofborg bot requested a review from edwtjo December 7, 2019 18:17
tomberek
tomberek approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple version bump. Builds and runs on NixOS.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/98

@worldofpeace worldofpeace merged commit c6fa3c2 into NixOS:master Feb 11, 2020
@nyanloutre nyanloutre deleted the radarr_2_0_1450 branch February 11, 2020 22:22
@minijackson minijackson mentioned this pull request Feb 13, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @nixos-discourse @tomberek @worldofpeace