Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kaidan: init at 0.4.1 #75165

Closed
wants to merge 2 commits into from
Closed

kaidan: init at 0.4.1 #75165

wants to merge 2 commits into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 7, 2019

Motivation for this change

Ticks off a box in #62168.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @silverhook

@silverhook
Copy link
Contributor

silverhook commented Feb 25, 2020 •
edited

I’m far from any (actual) maintainer, but thanks for the notification. Looking forward to see it merged :)

@ajs124 ajs124 closed this Apr 22, 2020
@ajs124 ajs124 deleted the init/kaidan branch April 22, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @silverhook @doronbehar