Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames should know their handedness #2395

Closed
pleroy opened this issue Dec 7, 2019 · 1 comment
Closed

Frames should know their handedness #2395

pleroy opened this issue Dec 7, 2019 · 1 comment
Labels

Comments

@pleroy
Copy link
Member

pleroy commented Dec 7, 2019

... and it should be impossible (statically, as much as possible) to create an orthogonal map that violates handedness.

Challenges:

  • All the places where we use struct F; to create a handy frame.
  • Permutation which would require restructuring to separate direct from indirect permutations.
  • The Rotation in OrthogonalMap which can only be represented if we reify the intermediate frame.
  • The lack of a way to construct -Identity.
@pleroy pleroy added the cleanup label Dec 7, 2019
@pleroy
Copy link
Member Author

pleroy commented Jan 1, 2020

Fixed in #2399, #2404, #2406, #2407, #2408, #2409, #2410, #2413, #2414, and #2415.

@pleroy pleroy closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant