Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
sssd requires it when using Active Directory, otherwise we get:
Note that is not the latest version. The new one is more complex to update. It requires some python stuff. At least with 1.3.18 I can play with sssd.
I'm working on a nixos test to catch if sssd doesn't start but it will be for later.
#58380 will bring tdb to >= 1.4.0 if merged eventually.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)I only tested nixos/tests/samba.nix as I wasn't able to find out other tests depending on tdb.
I did join a samba active directory (that I set up for testing) with this.
/nix/store/7cslafmwm9qiar8yn5q227r61ycifqpi-tdb-1.3.16 94.1M
/nix/store/kac47wii2ml0x62wpzcr35x40mwrfvjg-tdb-1.3.18 94.1M
Notify maintainers
cc @