Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.jsonrpc-websocket: Fix build #75142

Merged
merged 1 commit into from Dec 7, 2019
Merged

python3Packages.jsonrpc-websocket: Fix build #75142

merged 1 commit into from Dec 7, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 7, 2019

Motivation for this change

Didn't build due to missing dep.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from peterhoeg December 7, 2019 09:02
@srhb
Copy link
Contributor

srhb commented Dec 7, 2019

Did you mean for this to be in nativeBuildInputs and if so, why

@etu
Copy link
Contributor Author

etu commented Dec 7, 2019

@srhb It seems (from the failure) to be needed by the build process.

@srhb srhb merged commit 96e0c90 into NixOS:master Dec 7, 2019
@etu etu deleted the fix-python-jsonrpc-websocket-build branch December 7, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @srhb