New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.transformers: init at 2.2.1 #75106
Conversation
@jonringer - thank you for your comments and pointers, fixed and rebased. Hope it's more consistent now. |
@GrahamcOfBorg build python27Packages.sacremoses python27Packages.sentencepiece python27Packages.transformers python37Packages.sacremoses python37Packages.sentencepiece python37Packages.transformers python38Packages.sacremoses python38Packages.sentencepiece python38Packages.transformers sentencepiece |
do you mind updating the platforms for the packages? I'm trying to not have broken arch or darwin packages get added. It's fine if this package just doesn't support those platforms |
@jonringer - done, hopefully correctly, once again, appreciate your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
[14 built, 4 copied (8.8 MiB), 1.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75106
10 package were built:
python27Packages.sacremoses python27Packages.sentencepiece python27Packages.transformers python37Packages.sacremoses python37Packages.sentencepiece python37Packages.transformers python38Packages.sacremoses python38Packages.sentencepiece python38Packages.transformers sentencepiece
@GrahamcOfBorg build python27Packages.sacremoses python27Packages.sentencepiece python27Packages.transformers python37Packages.sacremoses python37Packages.sentencepiece python37Packages.transformers python38Packages.sacremoses python38Packages.sentencepiece python38Packages.transformers sentencepiece |
been busy with real life + oni, sorry for not getting back to this faster |
@GrahamcOfBorg build python27Packages.sacremoses python27Packages.sentencepiece python27Packages.transformers python37Packages.sacremoses python37Packages.sentencepiece python37Packages.transformers python38Packages.sacremoses python38Packages.sentencepiece python38Packages.transformers sentencepiece |
platformo issues resolved |
@jonringer Thank you for your help! I learned a lot! |
Adding the transformers library for DeepLearning along side the dependencies to build it.
Motivation for this change
Wanted to build the transformers library for ML work.
This is my first PR into NixOS, so please let me know if I am doing something wrong and I will try to rectify this in the future, but I struggled quite a bit through this - so happy that it builds. This builds on my system and made sure this builds with Sandboxing.
Wasn't sure if I had to create multiple PR's for each separate package that transformers depends on, but it's all in here.
Tests for transformers exist, but i don't think they will work in sandboxing because they require downloading packages from s3, and also require to have tensorflow or pytorch installed... I will try to get them to work one more time, but failed on first try.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @jonringer @teh @FRidh - Not sure who I am supposed to be tagging for PR's that don't have any maintainers.