New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edbrowse: 3.7.4 -> 3.7.6 #75087
edbrowse: 3.7.4 -> 3.7.6 #75087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
executable still shows usage
[2 built, 4 copied (7.0 MiB), 1.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75087
1 package were built:
edbrowse
@GrahamcOfBorg build edbrowse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit fetched as a patch is now part of the version so it isn't needed anymore
Ok so this means that it isn't necessary to update it? (A bit confused here 😅 ) |
No, I just meant that you could remove the following block: patches = [
# Fix build against recent libcurl
(fetchpatch {
url = https://github.com/CMB/edbrowse/commit/5d2b9e21fdf019f461ebe62738d615428d5db963.diff;
sha256 = "167q8n0syj3iv6lxrbpv4kvb63j4byj4qxrxayy08bah3pss3gky";
})
]; because that patch isn't needed with the newer 3.7.6 version. (also remove |
Ohhhhhh... Got it! Will ammend ASAP 😄 |
+ turn makeFlags into a list + update meta.homepage
@equirosa just added a commit to update the hash of the source archive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nix-review pr 75087
1 package were build:
- edbrowse
$ ./results/edbrowse/bin/edbrowse -v
3.7.6
Motivation for this change
Newest version has a bunch of bug fixes, latest version within nixpkgs is from over a year ago.
https://github.com/CMB/edbrowse/releases/tag/v3.7.6
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @