Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-nginx-exporter: 0.4.2 -> 0.5.0 #75118

Merged
merged 1 commit into from Dec 7, 2019
Merged

prometheus-nginx-exporter: 0.4.2 -> 0.5.0 #75118

merged 1 commit into from Dec 7, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/nginxinc/nginx-prometheus-exporter/releases/tag/v0.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 6, 2019
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.nginx

@ofborg ofborg bot requested review from fpletz, globin, ehmry and benley December 6, 2019 20:59
@Ma27 Ma27 merged commit e93a260 into NixOS:master Dec 7, 2019
@WilliButz WilliButz deleted the update-nginx-exporter branch December 7, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@ehmry ehmry Awaiting requested review from ehmry

@benley benley Awaiting requested review from benley

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27