New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beets.externalPlugins.check: init at 0.12.0 #75136
Conversation
A test is still failing, I'm working on it |
d481dbc
to
b5a5c34
Compare
All fixed. |
This is completely impractical to test without diff --git a/pkgs/tools/audio/beets/default.nix b/pkgs/tools/audio/beets/default.nix
index 3c2c474240f..b4dfa71ca96 100644
--- a/pkgs/tools/audio/beets/default.nix
+++ b/pkgs/tools/audio/beets/default.nix
@@ -250,6 +250,10 @@ in pythonPackages.buildPythonApplication rec {
makeWrapperArgs = [ "--set GI_TYPELIB_PATH \"$GI_TYPELIB_PATH\"" "--set GST_PLUGIN_SYSTEM_PATH_1_0 \"$GST_PLUGIN_SYSTEM_PATH_1_0\"" ];
+ passthru = {
+ externalPlugins = plugins;
+ };
+
meta = {
description = "Music tagger and library organizer";
homepage = http://beets.io; Now I can actually build the external packages under |
@worldofpeace all fixed up :) |
b5a5c34
to
b257366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just maybe need a comment for the sed.
b257366
to
dd285c2
Compare
dd285c2
to
171ceb3
Compare
Motivation for this change
I need this plugin
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @aszlig @domenkozar @pjones