beets.externalPlugins.check: init at 0.12.0 #75136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test is still failing, I'm working on it |
lovesegfault
force-pushed
the
beets-check
branch
from
d481dbc
to
b5a5c34
Compare
|
All fixed. |
aszlig
approved these changes
Dec 14, 2019
|
This is completely impractical to test without diff --git a/pkgs/tools/audio/beets/default.nix b/pkgs/tools/audio/beets/default.nix
index 3c2c474240f..b4dfa71ca96 100644
--- a/pkgs/tools/audio/beets/default.nix
+++ b/pkgs/tools/audio/beets/default.nix
@@ -250,6 +250,10 @@ in pythonPackages.buildPythonApplication rec {
makeWrapperArgs = [ "--set GI_TYPELIB_PATH \"$GI_TYPELIB_PATH\"" "--set GST_PLUGIN_SYSTEM_PATH_1_0 \"$GST_PLUGIN_SYSTEM_PATH_1_0\"" ];
+ passthru = {
+ externalPlugins = plugins;
+ };
+
meta = {
description = "Music tagger and library organizer";
homepage = http://beets.io;Now I can actually build the external packages under |
|
@worldofpeace all fixed up :) |
lovesegfault
force-pushed
the
beets-check
branch
from
b5a5c34
to
b257366
Compare
worldofpeace
approved these changes
Dec 15, 2019
lovesegfault
force-pushed
the
beets-check
branch
from
b257366
to
dd285c2
Compare
lovesegfault
force-pushed
the
beets-check
branch
from
dd285c2
to
171ceb3
Compare
worldofpeace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I need this plugin
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @aszlig @domenkozar @pjones