Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

station: fix missing icon #76823

Merged
merged 1 commit into from Feb 3, 2020
Merged

station: fix missing icon #76823

merged 1 commit into from Feb 3, 2020

Conversation

epiteff
Copy link
Contributor

@epiteff epiteff commented Jan 2, 2020

Motivation for this change

Fixes the icon not displaying.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@epiteff
Copy link
Contributor Author

epiteff commented Jan 6, 2020

The maintainer @lattfein does not exist anymore. Could anyone review this PR?

@epiteff
Copy link
Contributor Author

epiteff commented Feb 1, 2020

@jonringer Could you review this PR?

@jonringer
Copy link
Contributor

I could, but I don't use a DE so I don't really see icons. @worldofpeace can you take a look? I know you like things looking polished.

worldofpeace
worldofpeace approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@worldofpeace
Copy link
Contributor

@jonringer yes 😄 polish always.

@worldofpeace worldofpeace merged commit 90e81f3 into NixOS:master Feb 3, 2020
@epiteff epiteff deleted the station-fix-missing-icon branch February 3, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@epiteff @jonringer @worldofpeace @Janik-Haag