Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/freeswitch: init #76821

Merged
merged 2 commits into from Jan 30, 2020
Merged

nixos/freeswitch: init #76821

merged 2 commits into from Jan 30, 2020

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 2, 2020

Motivation for this change

Basic FreeSWITCH module with configuration reload support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR overall! I can see you put some thought into it :)

nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Show resolved Hide resolved
nixos/tests/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, just saw something when rendering the manual. Turns out a few more literalExamples are needed for them to render nicely. I believe literalExample should be used in defaultText and example when the value represents a Nix value and not a string.

nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
@infinisil
Copy link
Member

You can render the manual yourself with nix-build nixos/release.nix -A manualHTML.x86_64-linux to see what it looks like.

@misuzu
Copy link
Contributor Author

misuzu commented Jan 27, 2020

Updated. Example's and Default's looks fine now.

@misuzu misuzu requested a review from infinisil January 27, 2020 12:34
@infinisil
Copy link
Member

@GrahamcOfBorg test freeswitch

nixos/tests/all-tests.nix Outdated Show resolved Hide resolved
@misuzu
Copy link
Contributor Author

misuzu commented Jan 30, 2020

@GrahamcOfBorg test freeswitch

@infinisil infinisil merged commit 2118cdd into NixOS:master Jan 30, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 30, 2020
nixos/freeswitch: init

(cherry picked from commit 2118cdd)
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

@misuzu misuzu deleted the freeswitch-module branch April 7, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants