Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/freeswitch: init #76821

Merged
merged 2 commits into from
Jan 30, 2020
Merged

nixos/freeswitch: init #76821

merged 2 commits into from
Jan 30, 2020
+138 −0

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 2, 2020

Motivation for this change

Basic FreeSWITCH module with configuration reload support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@misuzu misuzu requested a review from infinisil as a code owner January 2, 2020 13:02
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 2, 2020
infinisil
infinisil requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR overall! I can see you put some thought into it :)

@misuzu
freeswitch: include configuration templates, enable parallel building

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
ed41104
@misuzu misuzu force-pushed the freeswitch-module branch from 28bc9bb to 095e057 Compare January 7, 2020 14:55
@misuzu misuzu requested a review from infinisil January 7, 2020 15:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2020
infinisil
infinisil requested changes Jan 13, 2020
View reviewed changes
@misuzu misuzu force-pushed the freeswitch-module branch from 095e057 to 0c9ef9d Compare January 15, 2020 09:42
infinisil
infinisil requested changes Jan 16, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, just saw something when rendering the manual. Turns out a few more literalExamples are needed for them to render nicely. I believe literalExample should be used in defaultText and example when the value represents a Nix value and not a string.

@infinisil
Copy link
Member

You can render the manual yourself with nix-build nixos/release.nix -A manualHTML.x86_64-linux to see what it looks like.

@misuzu misuzu force-pushed the freeswitch-module branch from 0c9ef9d to 1277b2f Compare January 27, 2020 12:31
@misuzu
Copy link
Contributor Author

misuzu commented Jan 27, 2020

Updated. Example's and Default's looks fine now.

@misuzu misuzu requested a review from infinisil January 27, 2020 12:34
@infinisil
Copy link
Member

@GrahamcOfBorg test freeswitch

infinisil
infinisil requested changes Jan 30, 2020
View reviewed changes
@misuzu misuzu force-pushed the freeswitch-module branch from 1277b2f to 0a43e43 Compare January 30, 2020 15:17
@misuzu
Copy link
Contributor Author

misuzu commented Jan 30, 2020

@GrahamcOfBorg test freeswitch

@infinisil infinisil merged commit 2118cdd into NixOS:master Jan 30, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 30, 2020
@infinisil @dtzWill
nixos/freeswitch: init (NixOS#76821)
1c98a7f 
nixos/freeswitch: init

(cherry picked from commit 2118cdd)
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@infinisil @anna328p
nixos/freeswitch: init (NixOS#76821)
3a26944 
nixos/freeswitch: init
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

@misuzu misuzu deleted the freeswitch-module branch April 7, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misuzu @infinisil @nixos-discourse