Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntl: 11.4.1 -> 11.4.2, gf2x: 1.2 -> 1.3.0 #76829

Merged
merged 2 commits into from Jan 2, 2020
Merged

ntl: 11.4.1 -> 11.4.2, gf2x: 1.2 -> 1.3.0 #76829

merged 2 commits into from Jan 2, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 2, 2020 •
edited

Motivation for this change

gf2x was updated, ntl needs an update for compatibility. See #45299.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
ntl: 11.4.1 -> 11.4.2
d41ff9b 
Needed for gf2x 1.3.0 compatibility. Upstream says:

> I just uploaded NTL 11.4.2 to http://www.shoup.net/ntl

> This fixes a few small, obscure bugs, including one that  prevents using
> the gf2x-1.3 library.

At https://groups.google.com/d/msgid/sage-devel/992c77f6-ebf9-4049-8900-c45c6b89f4ed%40googlegroups.com
@timokau
gf2x: 1.2 -> 1.3.0
45e3be9 
Switch source to fetchgit since it removes the requirements to manually
find the correct link for each version.

More information at
NixOS#45299
@timokau timokau mentioned this pull request Jan 2, 2020
Merged
9 tasks
@ofborg ofborg bot requested a review from 7c6f434c January 2, 2020 17:05
@timokau timokau merged commit 552b38e into NixOS:master Jan 2, 2020
@timokau timokau deleted the gf2x-1.3.0 branch January 2, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau