Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comby: init at 0.12.1 #76828

Closed
wants to merge 5 commits into from
Closed

comby: init at 0.12.1 #76828

wants to merge 5 commits into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Jan 2, 2020 •
edited

Motivation for this change

https://github.com/comby-tools/comby/releases/tag/0.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

lukateras
lukateras reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't build:

(cd _build/default && .ppx/3a48ee47a0ff6f2bd43558b49bc4d853/ppx.exe --conditional --cookie 'library-name="server_types"' -o lib/server/server_types.pp.ml --impl lib/server/server_types.ml --dump-ast)
.ppx/3a48ee47a0ff6f2bd43558b49bc4d853/ppx.exe: unknown option '--conditional'.
builder for '/nix/store/y0wq6bdvfgywg2hcna23ix6x5g7q620f-ocaml4.07.1-comby-0.12.1.drv' failed with 
exit code 1
error: build of '/nix/store/y0wq6bdvfgywg2hcna23ix6x5g7q620f-ocaml4.07.1-comby-0.12.1.drv' failed

pkgs/development/ocaml-modules/hack_parallel/default.nix Outdated

buildInputs = [ core ppx_deriving ppxlib sexplib ];

patches = [ ./dune-static-libs.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: technically it's a diff, not a patch :) Compare:

@lukateras
Copy link
Member

@GrahamcOfBorg build comby

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 19, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@JohnAZoidberg
Copy link
Member

Still interested!

@kvtb kvtb mentioned this pull request Feb 10, 2021
Merged
10 tasks
@kvtb
Copy link
Contributor

kvtb commented Feb 10, 2021

There is upstream interest to get it packed in nixpkgs (likely the author is Nix/Darwin user)
comby-tools/comby#142

Br1ght0ne and others added 5 commits February 13, 2021 18:14
@Br1ght0ne @JohnAZoidberg
ocamlPackages.hack_parallel: init at 0.1.1
74e209d
@Br1ght0ne @JohnAZoidberg
comby: init at 0.12.1
6919a41
@JohnAZoidberg
rename patch to diff
5992fab
@JohnAZoidberg
comby, hack_parallel: Use Dune2
b5bdc1d 
File "/nix/store/5j7s3mgkvx6l0cgk7wvrbzznfq4msbaw-ocaml4.10.0-core_kernel-0.14.0/lib/ocaml/4.10.0/site-lib/core_kernel/dune-package", line 1, characters 11-14:
1 | (lang dune 2.8)
               ^^^
Error: Version 2.8 of dune is not supported.
Supported versions:
- 0.0
- 1.0 to 1.11
Done: 0/0 (jobs: 0)
@JohnAZoidberg
mparser-comby: init at 8de1895f6f4e48e19280ec37f3e
b4d8ffe
@JohnAZoidberg
Copy link
Member

I rebased it onto master and fixed a few things:

  • Rename the patch file to diff
  • Enable useDune2 = true because that's apparently required now.

And because comby depends on a few custom dependencies we need to either push upstream to upstream their forked dependency changes or patch/package those (see https://github.com/comby-tools/comby/blob/master/comby.opam):

  • mparser-comby: I temporarily added a new file for this
  • patdiff: Requires a different branch that doesn't cleanly merge with upstream, so I can't create a patch file (https://github.com/rvantonder/patdiff.git#0.13.0-patch-compatible-diffs)
  • hack_parallel: Not sure if this is the correct version
  • bisect_ppx: Not sure if this causes issues
  • camlzip: Not sure if this causes issues

@NixOS NixOS deleted a comment from stale bot Feb 13, 2021
@kvtb
Copy link
Contributor

kvtb commented Feb 13, 2021

1.0.0 is released, hack_parallel can be trivially updated, but comby is tricky

@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2021
@dywedir
Copy link
Member

dywedir commented Nov 21, 2021

Thanks!
Closing the PR, please see #123986, #139408

@dywedir dywedir closed this Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras left review comments

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid ulrikstrid will be requested when the pull request is marked ready for review ulrikstrid is a code owner

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Br1ght0ne @lukateras @JohnAZoidberg @kvtb @dywedir @ryantm