comby: init at 0.12.1 #76828
Closed
comby: init at 0.12.1 #76828
+155
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Br1ght0ne
force-pushed
the
comby-0.12.1
branch
from
faa7246 to
228627d
Compare
ofborg
bot
added
10.rebuild-darwin: 0
lukateras
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Doesn't build:
(cd _build/default && .ppx/3a48ee47a0ff6f2bd43558b49bc4d853/ppx.exe --conditional --cookie 'library-name="server_types"' -o lib/server/server_types.pp.ml --impl lib/server/server_types.ml --dump-ast)
.ppx/3a48ee47a0ff6f2bd43558b49bc4d853/ppx.exe: unknown option '--conditional'.
builder for '/nix/store/y0wq6bdvfgywg2hcna23ix6x5g7q620f-ocaml4.07.1-comby-0.12.1.drv' failed with
exit code 1
error: build of '/nix/store/y0wq6bdvfgywg2hcna23ix6x5g7q620f-ocaml4.07.1-comby-0.12.1.drv' failed
|
|
||
| buildInputs = [ core ppx_deriving ppxlib sexplib ]; | ||
|
|
||
| patches = [ ./dune-static-libs.patch ]; |
There was a problem hiding this comment.
Nitpick: technically it's a diff, not a patch :) Compare:
|
@GrahamcOfBorg build comby |
stale
bot
added
the
2.status: stale
ryantm
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
ryantm
added
2.status: merge conflict
|
Still interested! |
10 tasks
|
There is upstream interest to get it packed in |
File "/nix/store/5j7s3mgkvx6l0cgk7wvrbzznfq4msbaw-ocaml4.10.0-core_kernel-0.14.0/lib/ocaml/4.10.0/site-lib/core_kernel/dune-package", line 1, characters 11-14:
1 | (lang dune 2.8)
^^^
Error: Version 2.8 of dune is not supported.
Supported versions:
- 0.0
- 1.0 to 1.11
Done: 0/0 (jobs: 0)
JohnAZoidberg
force-pushed
the
comby-0.12.1
branch
from
228627d to
b4d8ffe
Compare
ofborg
bot
removed
the
2.status: merge conflict
|
I rebased it onto master and fixed a few things:
And because comby depends on a few custom dependencies we need to either push upstream to upstream their forked dependency changes or patch/package those (see https://github.com/comby-tools/comby/blob/master/comby.opam):
|
|
|
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/comby-tools/comby/releases/tag/0.12.1
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)This change is