Skip to content

Fix postgresql typed #76819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Fix postgresql typed #76819

merged 1 commit into from
Jan 4, 2020
+4 −1

Conversation

BrianHicks
Copy link
Contributor

Motivation for this change

postgresql-typed was marked as broken in the latest nixpkgs. This fixes it by disabling the test suite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@BrianHicks
postgresql-typed: disable test suite
cce402c 
the test suite requires a running PostgreSQL instance to complete
successfully, so we'll just skip that.
@BrianHicks BrianHicks changed the base branch from master to haskell-updates January 2, 2020 12:36
@cdepillabout
Copy link
Member

@BrianHicks Looks good. This built for me. Thanks!

@cdepillabout cdepillabout merged commit 6d6a8e3 into NixOS:haskell-updates Jan 4, 2020
@BrianHicks BrianHicks deleted the fix-postgresql-typed branch January 14, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@cdepillabout cdepillabout

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrianHicks @cdepillabout