pythonPackages.alerta-server: refactor fix broken build #76789
Closed
+213
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
8.has: clean-up
8.has: package (new)
|
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
stale
bot
added
the
2.status: stale
doronbehar
requested changes
Sep 11, 2020
|
|
||
| meta = with lib; { | ||
| description = "Python wrapper around Lua and LuaJIT"; | ||
| homepage = https://github.com/scoder/lupa; |
There was a problem hiding this comment.
Suggested change
| homepage = https://github.com/scoder/lupa; | |
| homepage = "https://github.com/scoder/lupa"; |
| }; | ||
|
|
||
| propagatedBuildInputs = [ | ||
| redis |
There was a problem hiding this comment.
Perhaps this should go to buildInputs?
stale
bot
removed
the
2.status: stale
|
Note the merge conflicts. |
doronbehar
added
the
2.status: stale
ryantm
added
the
2.status: merge conflict
|
See also #112125. |
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to op not responding and issue seems to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable all tests and fix broken builds in staging-next. In this case fix alerta-server and some of its dependencies
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @