Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chirp: 20191123 -> 20191221; add support for chirp.drivers.tk8180 #76801

Merged
merged 1 commit into from Jan 3, 2020
Merged

chirp: 20191123 -> 20191221; add support for chirp.drivers.tk8180 #76801

merged 1 commit into from Jan 3, 2020

Conversation

hax404
Copy link
Contributor

@hax404 hax404 commented Jan 1, 2020 •
edited

Motivation for this change

update to version 20191221 and add support for chirp.drivers.tk8180. The latter is done by adding the futures python module to dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny

@ofborg ofborg bot requested a review from the-kenny January 1, 2020 21:28
@fpletz fpletz merged commit 6a2caa5 into NixOS:master Jan 3, 2020
@hax404 hax404 deleted the chirp branch January 4, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hax404 @fpletz