Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.svgwrite: refactor fix broken build #76790

Merged
merged 1 commit into from Jan 3, 2020

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Jan 1, 2020

There was a single test in the build that tries to download a google
font.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

There was a single test in the build that tries to download a google
font.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

failure is from upstream python3.8 issue

[3 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/cz0m79jvblz8lbjkn99k0wnw9xzlkn4l-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/76790
2 package marked as broken and skipped:
python37Packages.qasm2image python38Packages.qasm2image

1 package failed to build:
python38Packages.svgwrite

2 package built:
python27Packages.svgwrite python37Packages.svgwrite

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.svgwrite python37Packages.svgwrite

@jonringer jonringer merged commit 6e02629 into NixOS:staging-next Jan 3, 2020
@FRidh
Copy link
Member

FRidh commented Jan 3, 2020

this targeted staging-next. You could push this commit directly to master now and just leave it on staging-next.

@jonringer
Copy link
Contributor

on master as 7c85d7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants