Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcli: init at 1.8.2 #76791

Merged
merged 2 commits into from Jan 2, 2020
Merged

kcli: init at 1.8.2 #76791

merged 2 commits into from Jan 2, 2020

Conversation

cswank
Copy link

@cswank cswank commented Jan 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

subPackages = [ "." ];

meta = with stdenv.lib; {
description = "A kafka command line browser.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot at the end should be omited iirc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/kcli/default.nix Show resolved Hide resolved
pkgs/development/tools/kcli/default.nix Outdated Show resolved Hide resolved
@kalbasit
Copy link
Member

kalbasit commented Jan 2, 2020

@GrahamcOfBorg build kcli

@kalbasit kalbasit merged commit 43e14ef into NixOS:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants