WIP grpc: fix static musl build #76877

FRidh · 2020-01-03T12:40:29Z

Motivation for this change

Things done

Notify maintainers

cc @

FRidh · 2020-01-03T12:41:06Z

pkgs/development/compilers/gcc/9/default.nix

@@ -5,7 +5,7 @@
 , langGo ? false
 , profiledCompiler ? false
 , staticCompiler ? false
-, enableShared ? true
+, enableShared ? !stdenv.targetPlatform.isMusl


this is an ugly fix for protobuf #76873

@FRidh Perhaps we could fix it better by removing .la files, like some packages like SDL do which say that pkgconfig is much better at handling this than libtool (which I think is true):

nixpkgs/pkgs/development/libraries/SDL2/default.nix

Lines 78 to 94 in 201d9b8

# We remove libtool .la files when static libs are requested,

# because they make the builds of downstream libs like `SDL_tff`

# fail with `cannot find -lXext, `-lXcursor` etc. linker errors

# because the `.la` files are not pruned if static libs exist

# (see https://github.com/NixOS/nixpkgs/commit/fd97db43bcb05e37f6bb77f363f1e1e239d9de53)

# and they also don't carry the necessary `-L` paths of their

# X11 dependencies.

# For static linking, it is better to rely on `pkg-config` `.pc`

# files.

postInstall = ''

if [ "$dontDisableStatic" -eq "1" ]; then

rm $out/lib/*.la

else

rm $out/lib/*.a

fi

moveToOutput bin/sdl2-config "$dev"

'';

But when I try this here for gcc9 (on master, not staging-next), the GCC build fails even before postInstall is run:

/build/build/./gcc/xgcc -B/build/build/./gcc/ -xc++ -nostdinc /dev/null -S -o /dev/null -fself-test=../../gcc-9.2.0/gcc/testsuite/selftests /nix/store/n9acaakxahkv1q3av11l93p7rgd4xqsf-bootstrap-tools/bin/bash: /build/build/./gcc/xgcc: No such file or directory ../../gcc-9.2.0/gcc/cp/Make-lang.in:178: recipe for target 's-selftest-c++' failed make[3]: *** [s-selftest-c++] Error 127 rm gcc.pod make[3]: Leaving directory '/build/build/gcc'

Impurity?

FRidh · 2020-01-03T12:41:16Z

Does not build yet

tobim · 2020-01-18T21:20:55Z

pkgs/development/libraries/grpc/default.nix

@@ -27,8 +29,9 @@ stdenv.mkDerivation rec {
      "-DgRPC_SSL_PROVIDER=package"
      "-DgRPC_PROTOBUF_PROVIDER=package"
      "-DgRPC_GFLAGS_PROVIDER=package"
-      "-DBUILD_SHARED_LIBS=ON"
+      "-DBUILD_SHARED_LIBS=${if enableShared then "ON" else "OFF"}"


This should not be necessary since the makeStaticLibraries adapter appends -DBUILD_SHARED_LIBS=OFF already.

stale · 2020-07-17T02:53:33Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unpriviledged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

stale · 2021-06-04T14:02:44Z

I marked this as stale due to inactivity. → More info

tobim · 2022-11-27T21:33:58Z

pkgsStatic.grpc builds successfully on nixpkgs-unstable. I guess this won't be necessary anymore.

superherointj · 2023-01-10T13:23:35Z

I confirm pkgsStatic.grpc builds at master, nixos-unstable.

@FRidh Can this be closed?

FRidh added 2 commits January 3, 2020 13:39

WIP gcc9: don't build shared libraries in case of musl

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: C5517DE1649AB165

Learn about vigilant mode

c5c137d

WIP: grpc fix static musl build

273c56b

FRidh requested a review from matthewbauer as a code owner January 3, 2020 12:40

FRidh commented Jan 3, 2020

View reviewed changes

FRidh added the 6.topic: static label Jan 3, 2020

ofborg bot requested review from LnL7 and marsam January 3, 2020 12:59

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jan 3, 2020

tobim reviewed Jan 18, 2020

View reviewed changes

stale bot added the 2.status: stale label Jul 17, 2020

ryantm added the 2.status: merge conflict label Oct 3, 2020

stale bot removed the 2.status: stale label Oct 3, 2020

ryantm marked this pull request as draft October 23, 2020 03:03

spease mentioned this pull request Jan 11, 2021

Static linking protobuf for gnu64/musl64 fails due to libstdc++.so link attempt #108534

Closed

stale bot added the 2.status: stale label Jun 4, 2021

stale bot removed the 2.status: stale label Nov 27, 2022

Artturin closed this Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP grpc: fix static musl build #76877

WIP grpc: fix static musl build #76877

FRidh commented Jan 3, 2020

FRidh Jan 3, 2020

nh2 Jan 18, 2020

FRidh commented Jan 3, 2020

tobim Jan 18, 2020

stale bot commented Jul 17, 2020

stale bot commented Jun 4, 2021

tobim commented Nov 27, 2022

superherointj commented Jan 10, 2023 •

edited

Loading

	# We remove libtool .la files when static libs are requested,
	# because they make the builds of downstream libs like `SDL_tff`
	# fail with `cannot find -lXext, `-lXcursor` etc. linker errors
	# because the `.la` files are not pruned if static libs exist
	# (see https://github.com/NixOS/nixpkgs/commit/fd97db43bcb05e37f6bb77f363f1e1e239d9de53)
	# and they also don't carry the necessary `-L` paths of their
	# X11 dependencies.
	# For static linking, it is better to rely on `pkg-config` `.pc`
	# files.
	postInstall = ''
	if [ "$dontDisableStatic" -eq "1" ]; then
	rm $out/lib/*.la
	else
	rm $out/lib/*.a
	fi
	moveToOutput bin/sdl2-config "$dev"
	'';

WIP grpc: fix static musl build #76877

WIP grpc: fix static musl build #76877

Conversation

FRidh commented Jan 3, 2020

Motivation for this change

Things done

Notify maintainers

FRidh Jan 3, 2020

Choose a reason for hiding this comment

nh2 Jan 18, 2020

Choose a reason for hiding this comment

FRidh commented Jan 3, 2020

tobim Jan 18, 2020

Choose a reason for hiding this comment

stale bot commented Jul 17, 2020

stale bot commented Jun 4, 2021

tobim commented Nov 27, 2022

superherointj commented Jan 10, 2023 • edited Loading

superherointj commented Jan 10, 2023 •

edited

Loading