Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #76875

Merged
merged 43 commits into from Jan 6, 2020
Merged

Staging next #76875

merged 43 commits into from Jan 6, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

flokli and others added 30 commits December 22, 2019 17:35
CMake is used for static builds because the Makefile does not
offer a way to disable the shared library.
Even upstream no longer ships Autotools build files.
sourced from debian as patch isn't even in upstream master yet.
Fetch from github release page,
as that's where https://releases.llvm.org/9.0.1 redirects.
arrow-cpp: add pkgsStatic support
There was a single test in the build that tries to download a google
font.
@FRidh
Copy link
Member Author

FRidh commented Jan 3, 2020

@adisbladis please do not merge new updates after branching and evaluation.

@FRidh FRidh merged commit 3cf2c4c into master Jan 6, 2020
FRidh added a commit that referenced this pull request Sep 27, 2020
The change in `static.nix` was added in
#76875 but apparently
`enabledShared` got removed in the master/staging-next merge.
FRidh added a commit that referenced this pull request Sep 27, 2020
The change in `static.nix` was added in
#76875 but apparently
`enabledShared` got removed in the master/staging-next merge.

(cherry picked from commit 759a281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet