More or less complete rework of the page header #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. Can you rebase to get rid of the merge commit? We don't like those :) |
I'm a bit at a loss. How to rebase "to get rid of the merge commit"? I've never done that before … Or do you mean a simple squash? Can you please provide a link if you mean something different? Xth edit: I think, I'm back on the track. Tie the branch to another commit (current last commit) of the master branch. |
|
Basically just rebase as you would normally - the merge commit will disappear |
- it makes background-size abdicable - better understandable wording with keyword "to bottom" instead "0deg"
…tainers simpler Remove floating and margin from #openttd-logo and adjust the box height in this process.
LordAro
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the rtl-issue, desccribed in #117, I began to rework the header section. Follwoing changes are part of the PR.
backgroundI have a question about tha last point. I added the whole list of selectors whose names begins with
#openttd-logo-textbut I have no clue if some of them might be not in use here. Some of them i.e. like *-bananas, *-noai seems to be intended for use on different subdomains. Are there selectors I can remove without breaking things on another place?Edit: Forgot to add the screenshots for ltr (left-to-right-languages) and rtl ones.
left to right:
right to left:
