Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference_radius defaults to radius in the configuration of an oblate body #2430

Merged
merged 3 commits into from
Jan 3, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jan 2, 2020

Also regenerate the config files since apparently we forgot to do that when we removed mean_radius.

Also edited to wiki to remove references to mean_radius.

Fix #2429.

geopotential = node.GetBodyGeopotentialElements().ToArray()
reference_radius =
node?.GetAtMostOneValue("reference_radius") ??
(j2 != null || geopotential != null ? body.Radius + " m" : null),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it required for NewCartesianBodyParameters, i.e., revert the changes in this function.
See the comment about nominal vs. sufficient in the documentation: NewCartesianBodyParameters is the sufficient path.

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reference_radius does not appear to take a default value C#-side
2 participants