Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gflags: fix static musl build #76833

Closed
wants to merge 1 commit into from
Closed

gflags: fix static musl build #76833

wants to merge 1 commit into from
+14 −3

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 2, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 2, 2020
@veprbl veprbl mentioned this pull request Jan 2, 2020
Merged
10 tasks
veprbl
veprbl approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[nix-shell:~/.cache/nixpkgs-review/pr-76833/nixpkgs]$ ls -1 $(nix-build . -A gflags)/lib
cmake
libgflags.a
libgflags_nothreads.a
libgflags_nothreads.so
libgflags_nothreads.so.2.2
libgflags_nothreads.so.2.2.2
libgflags.so
libgflags.so.2.2
libgflags.so.2.2.2
pkgconfig

[nix-shell:~/.cache/nixpkgs-review/pr-76833/nixpkgs]$ ls -1 $(nix-build . -A pkgsStatic.gflags)/lib
cmake
libgflags.a
libgflags_nothreads.a
pkgconfig

@FRidh
Copy link
Member Author

FRidh commented Jan 3, 2020

merged 93da24c instead

@FRidh FRidh closed this Jan 3, 2020
@FRidh FRidh added the 6.topic: static Static builds (e.g. pkgsStatic) label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl

Assignees
No one assigned
Labels
6.topic: static Static builds (e.g. pkgsStatic) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @veprbl