Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivan: add icon and desktop item #76792

Merged
merged 1 commit into from Jan 9, 2020
Merged

ivan: add icon and desktop item #76792

merged 1 commit into from Jan 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 1, 2020

Motivation for this change

I added the application icon and the desktop item for better usability. 馃懡

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build ivan

ivan
ivan reviewed Jan 8, 2020
View reviewed changes
pkgs/games/ivan/default.nix Outdated
@@ -1,4 +1,5 @@
{ stdenv, fetchFromGitHub, cmake, pkgconfig, SDL2, SDL2_mixer, alsaLib, libpng, pcre }:
{ stdenv, fetchFromGitHub, cmake, pkgconfig, SDL2, SDL2_mixer, alsaLib, libpng,
pcre, graphicsmagick, makeDesktopItem }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think starting with e.g. , pcre is the accepted way to continue these lines

@ivan
Copy link
Member

ivan commented Jan 8, 2020

LGTM other than that nit

@grahamc grahamc merged commit b1e9876 into NixOS:master Jan 9, 2020
@ghost
Copy link
Author

ghost commented Jan 11, 2020

@ivan @grahamc Thanks! 馃懡

@ghost ghost mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @grahamc