Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash-my-aws: init at 20200111 #76793

Merged
merged 2 commits into from Feb 5, 2020
Merged

bash-my-aws: init at 20200111 #76793

merged 2 commits into from Feb 5, 2020

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Jan 1, 2020

Motivation for this change

Add bash-my-aws to nixpkgs

Things done
  • add package
  • add program module
  • tested on NixOS

Note: the package needs to be initialized by sourcing an alias and bash_completions for some features. Otherwise the bma script in /bin is still functional. Non-NixOS could use eval $(bma-init) that performs the above actions, but that might be the prerogative of upstream.

Another (perhaps better) option is to incorporate into home-manager so we don't have to patch the hard-coded location away.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tomberek
Copy link
Contributor Author

tomberek commented Jan 1, 2020

WIP: home-manager approach: https://github.com/tomberek/home-manager/blob/bash-my-aws/init/modules/programs/bash-my-aws.nix

That allows us to remove the entire postFixup phase. But that has less compatibility with non-HomeManager users.

@tomberek tomberek changed the title bash-my-aws: init at 20191231 bash-my-aws: init at 20200111 Jan 12, 2020
@tomberek tomberek mentioned this pull request Jan 28, 2020
Closed
danbst
danbst approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@danbst danbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@danbst danbst merged commit 437e1f6 into NixOS:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst danbst approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomberek @danbst