Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TimeDate: fix tests that fail as of 2020 #76810

Merged
merged 1 commit into from Jan 3, 2020
Merged

perlPackages.TimeDate: fix tests that fail as of 2020 #76810

merged 1 commit into from Jan 3, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 2, 2020

Motivation for this change

Same as #76809 but sending to staging, fixing branch name O:)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@urbas urbas mentioned this pull request Jan 2, 2020
Closed
10 tasks
@FRidh
Copy link
Member

FRidh commented Jan 3, 2020

there was once a PR that also proposed using libfaketime #2281

@FRidh FRidh added this to Needs review in Staging Jan 3, 2020
@FRidh FRidh changed the base branch from staging to staging-next January 3, 2020 17:11
@FRidh FRidh merged commit 336155c into NixOS:staging-next Jan 3, 2020
Staging automation moved this from Needs review to Done Jan 3, 2020
@dtzWill dtzWill deleted the fix/perl-timedate-2020 branch January 3, 2020 18:14
@thefloweringash thefloweringash mentioned this pull request Jan 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbas urbas urbas approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @FRidh @urbas