Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: fix dispatcherScripts example #76783

Merged
merged 1 commit into from Jan 1, 2020

Conversation

timjb
Copy link
Contributor

@timjb timjb commented Jan 1, 2020

Motivation for this change

Before, the example script didn't actually exit when the event type didn't match "up" despite logging a message saying it would do so.

Things done

Copied fixed example to my config, checked that the locks doesn't contain "Device $DEVICE_IFACE coming up" after disabling WIFI using NetworkManager.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Before, the example script didn't actually exit when the event type
didn't match "up".
@flokli
Copy link
Contributor

flokli commented Jan 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants