Skip to content

gi-gdkx11: Default to 3.X version #76883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

gi-gdkx11: Default to 3.X version #76883

wants to merge 15 commits into from
+1,335 −587

Conversation

mdorman
Copy link
Contributor

@mdorman mdorman commented Jan 3, 2020

The newer (4.X) versions require gtk4 which shouldn't be the default.

Motivation for this change

Fixes all packages that depend on gi-gdkx11 (which wasn't able to build since gtk4 isn't available in Nix)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

Sorry, something went wrong.

peti and others added 14 commits December 28, 2019 02:30
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
04321ee 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@5ccecb7.
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
adfee06 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@bb9a7bf.
@peti
LTS Haskell 14.19

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
669b5f2
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
50c5a92 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@b56d8e5.
@peti
ghc-8.10.x: exceptions is now a core library that comes with the comp…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
24ae311 
…iler
@peti
hackage2nix: update list of broken builds

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
a88c5f0
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
07d0412 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@5b45257.
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
906eb05 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@d07acf4.
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
9a627cf 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@a306985.
@donatello
haskellPackages.webby: mark unbroken

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
12d5809 
Builds fine now.
@cdepillabout
Merge pull request NixOS#76726 from donatello/haskell-updates

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
2cd291a 
haskellPackages.webby: mark unbroken
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
d264118 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@314df3f.
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
60e88ef 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@2b3fecd.
@peti
hackage-packages.nix: automatic Haskell package set update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
91bd396 
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision
commercialhaskell/all-cabal-hashes@bb864b3.
@ofborg ofborg bot added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 3, 2020
@cdepillabout
Copy link
Member

@mdorman Thanks for trying to fix this.

However, the default-package-overrides section is generated semi-automatically and shouldn't be added to by hand.

I just sent a PR adding a comment to try to clarify this. Please feel free to comment on this PR if anything is still unclear: #76912.

As for gi-gdkx11, there isn't a good way to default to an older version of a package that is not on Stackage. I'd urge you to try to get upstream to the package into Stackage so that we don't have to necessarily do anything here in nixpkgs.

If you wanted to explicitly generate an older version of a package, you can add it to this list:

nixpkgs/pkgs/development/haskell-modules/configuration-hackage2nix.yaml

Line 2494 in 8a4d94c

extra-packages:

@mdorman
taffybar: fix gi-gdkx11 dependency

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Ma27 Maximilian Bosch
GPG key ID: 091DBF4D1FC46B8E
Expired
Verified
Learn about vigilant mode
d886453 
haskellPackages chooses to default to the newer (4.X) gtk4 versions,
even though nix doesn't provide the necessary libraries.

This change makes sure that the gtk3 version of gi-gdkx11 will be
available after the next package update, and provides an override so
that taffybar will use it and thus be compilable.
@peti
Copy link
Member

peti commented Jan 5, 2020

The default-package-overrides section is generated semi-automatically and shouldn't be added to by hand.

Note that you can edit default-package-overrides by hand. The code that generates part of that section from Stackage looks for the comment "# LTS Haskell" and replaces everything that follows it until the end of the section: https://github.com/NixOS/cabal2nix/blob/master/update-stackage.sh#L46-L54.

In other words, if you add manual overrides before that comment, then it should be fine.

@peti peti force-pushed the haskell-updates branch 7 times, most recently from 23eb5a9 to 24ebeb9 Compare January 5, 2020 14:32
@peti peti force-pushed the haskell-updates branch from 24ebeb9 to 3ab6627 Compare January 5, 2020 19:44
@cdepillabout cdepillabout mentioned this pull request Jan 6, 2020
Merged
10 tasks
@peti peti force-pushed the haskell-updates branch 6 times, most recently from 5011d9e to 0685be7 Compare January 10, 2020 19:56
@cdepillabout cdepillabout mentioned this pull request Jan 16, 2020
Closed
@peti
Copy link
Member

peti commented Jan 17, 2020

@mdorman, will you update this PR?

@peti peti force-pushed the haskell-updates branch 5 times, most recently from b49676d to 6f8c1c9 Compare January 23, 2020 18:31
@peti
Copy link
Member

peti commented Jan 24, 2020

Please feel free to submit an updated PR when the issues pointed out during review are fixed.

@peti peti closed this Jan 24, 2020
@mdorman mdorman deleted the gi-gdkx11 branch March 5, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@cdepillabout cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdorman @cdepillabout @peti @donatello