Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: set next-gtk-webkit as a propagated build input #76838

Merged
merged 1 commit into from Jan 3, 2020
Merged

next: set next-gtk-webkit as a propagated build input #76838

merged 1 commit into from Jan 3, 2020

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jan 2, 2020

Fixes #76834.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nlewo
Copy link
Member Author

nlewo commented Jan 2, 2020

@GrahamcOfBorg build next

@jtojnar
Copy link
Contributor

jtojnar commented Jan 3, 2020

Could you add a comment why this is necessary? Likely something like compression preventing Nix from detecting the reference.

@nlewo
next: set next-gtk-webkit as a propagated build input
b664526 
Because this reference is unfortunately not detected by Nix.

Fixes NixOS#76834.
Br1ght0ne
Br1ght0ne approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable runs
the error reported by #76834 doesn't seem to occur

[2 built, 166 copied (453.1 MiB), 83.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76838
1 package built:
next

@nlewo nlewo merged commit 72d4651 into NixOS:master Jan 3, 2020
@jtojnar jtojnar mentioned this pull request Jan 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

next browser : next-gtk-webkit does not exists
3 participants
@nlewo @jtojnar @Br1ght0ne